Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MFA support #37

Closed
sushant-pradhan opened this issue Apr 16, 2018 · 5 comments
Closed

MFA support #37

sushant-pradhan opened this issue Apr 16, 2018 · 5 comments
Assignees
Labels
Projects

Comments

@sushant-pradhan
Copy link

Hello,

I see that the plugin doesn't support Multi Factor Authentication. I have my Azure side setup with OpenID (to prompt for MFA after login) and I am not getting prompted for MFA since scope argument isn't passed:

&scope=openid

Refer:
https://docs.microsoft.com/en-us/azure/active-directory/develop/active-directory-protocols-openid-connect-code

@hkamel
Copy link
Owner

hkamel commented Apr 18, 2018

Thanks @an-sush ... Hello @jmprieur should the authorization URL include the scope=openid to trigger the MFA or there is other way from AAD configurations?

@hkamel
Copy link
Owner

hkamel commented Apr 20, 2018

Hello @an-sush, I have tried the plug-in against my Azure AD tenant where MFA is enabled and it's working as expected. what exact error are you facing?

@hkamel hkamel self-assigned this Apr 20, 2018
@jmprieur
Copy link
Contributor

@hkamel if the tenant admin requires MFA for each sign-in, the scope=openid would be enough. Now if the tenant admin requires MFA for other resources that need to be accessed by the plug-in (I don't think that this would be the case for SonarQube / SonarCloud), the scope for this resource should also be provided, in the case of an AAD V1 app (as there is no dynamic consent, contrary to AAD V2)

@sushant-pradhan
Copy link
Author

Hello @hkamel with MFA turned on Azure side, the plugin is just prompting for password and not MFA. It allows login without MFA. Ideally it should challenge for MFA after entering credentials. The pull request #38 is fixing the issue and I have validated it

@hkamel hkamel added the bug label Apr 25, 2018
@hkamel
Copy link
Owner

hkamel commented Oct 4, 2018

A new draft release has been published 1.1-RC2 the announcement has been sent to the official SonarSource community to kick the official release.

@hkamel hkamel closed this as completed Oct 4, 2018
@srvrguy srvrguy added this to Done in Version 1.1 Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Version 1.1
  
Done
Development

No branches or pull requests

3 participants