Improvements and fixes for UCS #157

chengluyu · 2023-03-12T08:47:28Z

Change Logs

Add a complete test cases in UCS: untyped lambda calculus.
WIP test cases in UCS: simply typed lambda calculus.
Support alias clauses (e.g. ... and f(x) is y and ...).
No longer report inexhaustiveness when there is a default branch.
Fix missing interleaved computations in nested branches (examples added in d93e0d6).
Fix unhygienically extracting positional class parameters as described in UCS tracking issue #151.
Mark the source of let bindings so no we won't promote let bindings which is only accessible in a case branch to the level of its parent case expression. (Mentioned in this reply of UCS tracking issue #151)

Fix empty warnings of duplicated branches as described in UCS tracking issue #151.

fun testF(x) = if x is
  Foo(a) then a
  Foo(a) then a
//│ ╔══[WARNING] duplicated branch
//│ ╙──

Goals

Align with the paper.
Fix UCS tracking issue #151.

Non-Goals

Error messages and location reporting. This PR focuses more on making the UCS feature fully functional and minimizing errors.

chengluyu · 2023-03-12T14:33:02Z

Virtual Constructors

Two ideas for implementing virtual constructors (e.g. tuples).

Treat Tuple#n as an alias of tuple types in the typer. Then, translate Tuple#n as JavaScript predicates in the JS backend.
Type predicate function isTuple(t, n) in the typer and desugar tuple patterns to terms with reference to the function. Implement isTuple as a polyfill function in the JS backend.

…cs-paper

shared/src/test/diff/ucs/LitUCS.mls

shared/src/test/diff/ucs/WeirdIf.mls

I really need to go through the binding logic next.

shared/src/test/diff/ucs/InterleavedLet.mls

…cs-paper

chengluyu

I have checked all the test files and updated the tracking issue.

LPTK

Wow, impressive changes! But they still need a little polish.

shared/src/main/scala/mlscript/NewLexer.scala

js/src/main/scala/Main.scala

shared/src/main/scala/mlscript/ucs/Clause.scala

shared/src/main/scala/mlscript/ucs/Desugarer.scala

shared/src/test/diff/nu/BadUCS.mls

shared/src/test/diff/nu/repro_EvalNegNeg.mls

shared/src/test/diff/ucs/DirectLines.mls

shared/src/test/diff/ucs/Exhaustiveness.mls

shared/src/test/diff/tapl/NuSimplyTyped.mls

LPTK

Thanks, otherwise this looks good to me!

I'm a bit uncomfortable with the large code duplication introduced in your examples, but we can probably move these examples to the new compiler diff-tests later, where we'll be able to share some code in library files.

shared/src/test/diff/tapl/SimplyTyped.mls

shared/src/test/diff/nu/BadUCS.mls

shared/src/test/diff/parser/NuParser.mls

shared/src/test/diff/ucs/HygienicBindings.mls

LPTK · 2023-05-17T09:54:31Z

Ah, the build fails due to warnings. There were 34 before this PR and 35 now. Could you please try to solve the most obvious warnings, including specifically the one warning you introduced?

chengluyu · 2023-05-17T09:55:35Z

Sure. I will handle them later.

LPTK · 2023-05-17T09:59:55Z

Thanks! If there are some you're not sure how to deal with, leave them and I'll address them myself.

chengluyu · 2023-05-18T08:34:39Z

I tried to fix some warnings and non-exhaustive pattern errors. Now there remains 30 of them. It seems to go beyond the scope of what this PR should be responsible for if all of them need to be fixed. For example, the warning about asInstanceOf. So, I'll just do this much for now.

LPTK · 2023-05-18T09:49:27Z

Yes that's fine, we'll deal with the other warnings later. Let me know when I can merge.

LPTK · 2023-05-22T06:52:12Z

@chengluyu can I merge soon? One conversation is still open.

LPTK and others added 9 commits February 21, 2023 18:06

Add examples from meeting

d93e0d6

Add ne and eq to the JS polyfill

d76b9b0

No longer report inexhaustiveness when there is a default branch

4f0f870

Add an incomplete implementation of untyped lambda calculus

f7f0418

Support alias clauses and complete the ULC test cases

03a28b8

Update test files due to previous commits

d30b9c9

Add incomplete SLTC and built-in string comparison functions

2a7a5a7

Fix missing interleaved let bindings in nested branches

3d1018b

Fix unhygienically extracting positional class parameters

67513c1

chengluyu added 9 commits March 12, 2023 22:49

Merge remote-tracking branch 'lptk-fork/new-definition-typing' into u…

84b9ba7

…cs-paper

Use :NewDefs in lambda calculus test cases

e4dbbf7

Gather lambda calculus test files

3c9f9a1

Add incomplete JSON test cases and support escape chars in Lexer

a9c80d8

Merge remote-tracking branch 'lptk-fork/new-definition-typing' into u…

e7a9dd5

…cs-paper

Append test file updates

556eb26

No duplication when the else branch is taken at least once

32c70de

Add a more essential test case

c8ddd6e

Remove syntax highlight overrides for .mls files

aab8d27

LPTK reviewed Mar 15, 2023

View reviewed changes

shared/src/test/diff/ucs/LitUCS.mls Outdated Show resolved Hide resolved

LPTK reviewed Mar 15, 2023

View reviewed changes

shared/src/test/diff/ucs/WeirdIf.mls Outdated Show resolved Hide resolved

chengluyu added 2 commits March 15, 2023 16:37

No longer translate literal patterns to == applications

fef2c0c

Categorize let bindings so no longer missing alias patterns

8ac73ee

chengluyu force-pushed the ucs-paper branch from 2263d9f to 8ac73ee Compare March 15, 2023 08:38

chengluyu added 5 commits March 15, 2023 16:54

Improve warnings of duplicated branches

c8707c5

Improve the debug display of MutCaseOf

73dee4c

Fix duplicated interleaved bindings and missing alias bindings

e0f426a

I really need to go through the binding logic next.

Gather exhaustiveness information on the fly

1784ecb

Support basic else if composition

09a0fb9

LPTK reviewed Mar 16, 2023

View reviewed changes

shared/src/test/diff/ucs/InterleavedLet.mls Outdated Show resolved Hide resolved

chengluyu and others added 7 commits March 23, 2023 12:13

Support subclass refinement and preemptive wildcard branches

9a8e6aa

Consume MatchAny and try to merge inexhaustive branches

522f8fb

Add new UCS test cases

a35a416

Add zipWith tests

96cdb81

Add a couple small test cases

73dcda1

Support negative integers

b7a7cd5

Add some examples of unhygienic let bindings

d168eb5

chengluyu changed the base branch from mlscript to new-definition-typing May 4, 2023 09:53

chengluyu added 2 commits May 5, 2023 14:57

Merge remote-tracking branch 'lptk-fork/new-definition-typing' into u…

f6021f4

…cs-paper

Fix undefined is a keyword

2ff4c7b

chengluyu marked this pull request as ready for review May 5, 2023 06:59

Merge branch 'new-definition-typing' into ucs-paper

ee1ab19

chengluyu commented May 5, 2023

View reviewed changes

LPTK requested changes May 8, 2023

View reviewed changes

Fix comments

66d41f2

chengluyu requested a review from LPTK May 12, 2023 18:07

LPTK approved these changes May 17, 2023

View reviewed changes

Update CI: run on all PRs

34b1864

chengluyu added 3 commits May 18, 2023 16:00

Fix minor problems mentioned in PR comments

70fd442

Fix the warning in UCS source files

b89fa16

Try to fix more warnings

14a232a

Describe FIXME without actual errors

17d05de

LPTK merged commit 8ca4e93 into hkust-taco:new-definition-typing May 22, 2023
1 check failed

LPTK deleted the ucs-paper branch May 22, 2023 16:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improvements and fixes for UCS #157

Improvements and fixes for UCS #157

chengluyu commented Mar 12, 2023 •

edited

Loading

chengluyu commented Mar 12, 2023

chengluyu left a comment

LPTK left a comment

LPTK left a comment

LPTK commented May 17, 2023

chengluyu commented May 17, 2023

LPTK commented May 17, 2023

chengluyu commented May 18, 2023 •

edited

Loading

LPTK commented May 18, 2023

LPTK commented May 22, 2023 •

edited

Loading

Improvements and fixes for UCS #157

Improvements and fixes for UCS #157

Conversation

chengluyu commented Mar 12, 2023 • edited Loading

Change Logs

Goals

Non-Goals

chengluyu commented Mar 12, 2023

Virtual Constructors

chengluyu left a comment

Choose a reason for hiding this comment

LPTK left a comment

Choose a reason for hiding this comment

LPTK left a comment

Choose a reason for hiding this comment

LPTK commented May 17, 2023

chengluyu commented May 17, 2023

LPTK commented May 17, 2023

chengluyu commented May 18, 2023 • edited Loading

LPTK commented May 18, 2023

LPTK commented May 22, 2023 • edited Loading

chengluyu commented Mar 12, 2023 •

edited

Loading

chengluyu commented May 18, 2023 •

edited

Loading

LPTK commented May 22, 2023 •

edited

Loading