Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded Public Client URL #3

Closed
jeanlucmongrain opened this issue Mar 13, 2018 · 2 comments
Closed

Hardcoded Public Client URL #3

jeanlucmongrain opened this issue Mar 13, 2018 · 2 comments
Assignees

Comments

@jeanlucmongrain
Copy link

jeanlucmongrain commented Mar 13, 2018

It seem that the client URL hardcode https://localhost:8443:

this is problematic in many ways:

first, that port is not exposed https://github.com/hlavki/g-suite-identity-sync/blob/master/distribution/src/main/docker/Dockerfile#L29

then, how can my users access the web server of my deployment and authenticate?

https://localhost:8443 is a valid URL but only on the docker host. not where users are.

I want to use https://hub.docker.com/_/traefik/ to terminate https and forward traffic to the container.
So, hlavki/g-suite-identity-sync can either get it's hostname from the HTTP headers or from a configuration

@hlavki
Copy link
Owner

hlavki commented Mar 13, 2018

Thanks @bclermont for info. I'll look to traefik and try it.

@hlavki
Copy link
Owner

hlavki commented Mar 14, 2018

I fixed it and removed hostname configuration property and added compose example with traefik.

Important note is that you have to use at least version 0.3.1

@hlavki hlavki closed this as completed Mar 14, 2018
@hlavki hlavki self-assigned this Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants