Toolbar shows despite tool-bar-mode being disabled in emacs-app-devel MacPorts build of Emacs

[catap]

What did you expect to happen?

I expect that emacs won't have toolbar when it started, like it did before.

What actually happened?

Describe your attempts to resolve the issue

No response

Steps to reproduce

This issue happened after upgrading emacs via MacPorts. I'm using emacs-app-devel and after to last git master the issue appears: macports/macports-ports@2497386

Wired things, that if I Enter full screen at emacs — toolbar disappear. When I move back — it keeps to be disappeared.

System Information

https://pastebin.com/Z4j42wd6

[hlissner]

I do not have access to a macOS machine, but tool-bar-mode is disabled here and this appears to work fine in the emacs-plus and emacs-mac homebrew formulas for macOS, so I suspect this is a emacs-app-devel packaging issue, rather than a Doom issue.

I'll have to wait until a macos user with insight can chime in on the matter.

[catap]

@hlissner I guess you're looking for me because I'm a person who updated MacPorts ;)

It is original emacs with one small patch https://github.com/macports/macports-ports/blob/master/editors/emacs/files/site-start.el to make it compatible with MacPorts way to install something.

[catap]

The only way that I see right now is git bisect and find the exact commit which broke it. But it required to recompile emacs and doom for about ~10 times.

So, if you share any clue I'll be very appricieted :)

[catap]

I'd like to confirm that this isn't doom-emacs bug at all. The issue is related to emacs sources itself. A bit more than a month ago the upstream had changes that includes changing NS port resize detection and window handling which seems a root cause.

Thus, it is reported as https://debbugs.gnu.org/cgi/bugreport.cgi?bug=50534