Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flickering PDFs in pdf-view-mode #1107

Closed
wants to merge 1 commit into from
Closed

fix flickering PDFs in pdf-view-mode #1107

wants to merge 1 commit into from

Conversation

mnick
Copy link
Contributor

@mnick mnick commented Jan 10, 2019

Zooming into PDFs in PDFView conflicts with blinking cursors in evil-mode what causes the PDFs to flicker.

This applies the fix from politza/pdf-tools#201 what resolves the issue for me.

@hlissner
Copy link
Member

hlissner commented Jan 20, 2019

Sorry for the late response. Is there any reason we can't simply set evil-normal-state-cursor in this case? e.g.

-(set-evil-initial-state! 'pdf-view-mode 'emacs)
 (add-hook 'pdf-view-mode-hook
           (lambda ()
-            (set (make-local-variable 'evil-emacs-state-cursor) (list nil))))
+            (set (make-local-variable 'evil-normal-state-cursor) (list nil))))

evil-collection provides some evil integration for the pdf major modes. I'd like to preserve them, if possible.

Side note, setq-hook! may be more convenient here:

(setq-hook! 'pdf-view-mode-hook evil-normal-state-cursor (list nil))

hlissner added a commit that referenced this pull request Jan 23, 2019
@hlissner
Copy link
Member

As of 36a97b2, the alternative I suggested above is now in develop. Thanks for your help and for bringing this to my attention!

@hlissner hlissner closed this Jan 23, 2019
MarkRedeman pushed a commit to MarkRedeman/doom-emacs that referenced this pull request Mar 21, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants