New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
the '$' character is invalid. #10
Comments
thanks for the reproduction example. This is an old nemesis, I think there's time to fix this. The problem is that the dollar is maven package scope, and the fetchMavenArtifact isn't equiped to handle this. This needs to be added. I'll have a go at this. |
So I made a PR on nixpkgs, you can overlay your fetchMavenArtifact with my changes, crossing fingers it gets accepted. NixOS/nixpkgs#103755 |
To connect back to here, I made a comment and suggestion to the nixpkgs ticket: I think the correct approach would be to go with my suggested patch and then update this package to support converting the artifacts with Also I think after we resolve this, we can ping some of the maintainers in order to get some attention. As well as perhaps posting it to the PRs ready for review thread on NixOS discourse: |
A lot on my table atm, I read your comment and it makes total sense your solution. I will modify and follow up today or tomorrow, thank you! |
Thank you, no worries, take your time 😸 |
Sorry ㅎ.ㅎ g.g;; thanks thanks. |
I posted an issue about this a while back #6 |
@samrose yes I remember, sorry for not replying quickly enough. |
nixpkgs change has now been merged :) |
@hlolli no worries. I thought maybe I was raising a white elephant issue, so I closed it. (it definitely had the problems described, but I thought maybe I was missing some workaround) |
since NixOS/nixpkgs#103755 is merged now, anything stopping this from being updated to pass |
@glittershark blast from the past here. But do you remember what you ment by passing classifier correctly. Using the dollar symbol would be compatible with how tools.deps resolves classifier |
The path name 'org_openjfx_javafx-base$mac-14.jar' is invalid: the '$' character is invalid. Path names are alphanumeric and can include the symbols +-._?= and must not begin with a period. Note: If 'org_openjfx_javafx-base$mac-14.jar' is a source file and you cannot rename it on disk, builtins.path { name = ... } can be used to give it an alternative name.
CLJFX = (import ~/cljfx/deps.nix { inherit pkgs; }).makeClasspaths {};
install CLJFX~ I can't.
deps.edn is
https://github.com/cljfx/cljfx
When I checked the .m2 folder, the received file name is like this.
org.openjfx/javafx-base-14-mac.jar
Thanks
The text was updated successfully, but these errors were encountered: