Display shortcut hints for operators #190
Conversation
|
Really great addition and cleanup! I like the the hint to be displayed on top, right after the label. |
Just to clarify that, you would prefer the single short cut screen above right? (It's possible to update the tool's hint to have similar as above single short cut.) Also, for multiple shortcuts, would you be ok with above or also update to: |
Yeah, the same as in the screenshot you've posted.
Not sure about that, IMO both is okay. The only problem i see is that there's a maximum count of characters for the tooltip and it will get clipped if it's too long, so maybe better to display them inline. |
Ideally, I think one operator should do just one thing. It'll be less confusing. For example, direct distance, vertical distance and horizontal distance as there are actually different constraints IMO. It's clearer for user to use hot key as well. But I'll defer that for future discussion. Will update to be inlined for consistency for now |
|
There is really just one distance constraint now with the option to be aligned or not. So this currently communicates the implementation quite well. |
- Extract out all ids/ names into a separate module to be reused without introducing cycle dependencies. Also put all the names in one place - Original thought was to have each operator defines its own keymap (makes more sense in term single responsibility) but due to the nature of key mapping where management/cross reference are more important, move them to a common place keymaps.py to be shared across.
BaoNTGH
force-pushed
the
constraint_shortcut_hint
branch
from
8500991
to
46a07bc
Compare
Addressed all concerns. Took a chance to do much more cleaning up to reduce dependencies between modules.
|
|
Great, the only thing that's kinda missing is support for global keymaps, see: 0b22b0e. |
|
As this PR is kinda getting difficult to review i'm gonna merge this already. |
Yup, that could come later. There are a little more clean up to centralize all the key map at one place |
This is proposal for #95
reused without introducing cycle dependencies. Also put all the names
in one place
more sense in term single responsibility) but due to the nature of key
mapping where management/cross reference are more important, move them
to a common place keymaps.py to be shared across.
Multiple shortcuts:
Single shortcut:
