Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove thrift binary from Dockerfile? #11

Open
ccmaymay opened this issue Aug 14, 2022 · 1 comment
Open

Remove thrift binary from Dockerfile? #11

ccmaymay opened this issue Aug 14, 2022 · 1 comment

Comments

@ccmaymay
Copy link
Contributor

ccmaymay commented Aug 14, 2022

Accelerated thrift should be installed by pip at this point. If we want the thrift binary in a container for rebuilding the concrete source, it might make more sense to have a separate Dockerfile for that (like a "runtime" Dockerfile and a "development" Dockerfile).

c.f. analogous issue in concrete-js hltcoe/concrete-js#9

@ccmaymay
Copy link
Contributor Author

Added a development Dockerfile containing thrift to the concrete repo: https://github.com/hltcoe/concrete/blob/main/Dockerfile

@ccmaymay ccmaymay changed the title Remove standalone thrift installation from Dockerfile? Remove thrift binary from Dockerfile? Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant