Icons no longer appear after updated icon font

[scottkosty]

This issue is not urgent at all.

Starting with 01a2433 (found via bisect), the icons on the right side of the
main window do not appear for me. See the following screenshot:

This is from a custom-compiled CopyQ, so I'm probably missing a new dependency
but I'm not sure what it is. Here's some information that might be useful on my
system.

Operating system: Ubuntu 18.04.1.

$ sudo apt-get build-dep copyq
Reading package lists... Done
Reading package lists... Done
Building dependency tree       
Reading state information... Done
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
$ 

$ apt-cache policy fonts-font-awesome 
fonts-font-awesome:
  Installed: 4.7.0~dfsg-3
  Candidate: 4.7.0~dfsg-3
  Version table:
 *** 4.7.0~dfsg-3 500
        500 http://us.archive.ubuntu.com/ubuntu bionic/main amd64 Packages
        500 http://us.archive.ubuntu.com/ubuntu bionic/main i386 Packages
        100 /var/lib/dpkg/status

$ ./copyq --version
CopyQ Clipboard Manager v3.5.0-57-g50a89bc1
Built with: Qt 5.9.5

Here is the CMake output:

-- The C compiler identification is GNU 7.3.0
-- The CXX compiler identification is GNU 7.3.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Building with tests.
-- Found Git: /usr/bin/git (found version "2.17.1") 
-- Building CopyQ version v3.5.0-57-g50a89bc1.
-- Looking for XOpenDisplay in /usr/lib/x86_64-linux-gnu/libX11.so;/usr/lib/x86_64-linux-gnu/libXext.so
-- Looking for XOpenDisplay in /usr/lib/x86_64-linux-gnu/libX11.so;/usr/lib/x86_64-linux-gnu/libXext.so - found
-- Looking for gethostbyname
-- Looking for gethostbyname - found
-- Looking for connect
-- Looking for connect - found
-- Looking for remove
-- Looking for remove - found
-- Looking for shmat
-- Looking for shmat - found
-- Looking for IceConnectionNumber in ICE
-- Looking for IceConnectionNumber in ICE - found
-- Found X11: /usr/lib/x86_64-linux-gnu/libX11.so
-- Building for X11 window system.
-- Configuring done
-- Generating done

Here is the terminal output from running copyq:

DEBUG: Server "/home/scott/.config/copyq/.copyq_s" started.
DEBUG: Geometry: Window "ProcessManagerDialog": New geometry for "Options/ProcessManagerDialog_geometry_1600x900"
DEBUG: Geometry: Window "MainWindow": Restore geometry "Options/MainWindow_geometry": 645x421,0,0 -> 645x600,420,161
DEBUG: Focus window is "scott@barna: ~/Desktop/copyq_TEST"
DEBUG: Loading configuration
DEBUG: Tab "&1clipboard": Loading items
DEBUG: Tab "&1clipboard": 25 items loaded
DEBUG: Configuration loaded
DEBUG: Starting monitor
DEBUG: Executing: copyq monitorClipboard
DEBUG: Got save state request from session manager.

I have not tried yet from the PPA. I'm "worried" that I won't be able to
reproduce this issue after trying the PPA. (Although I could always use a
virtual box to make a fresh install to reproduce, if this would help).

[blueyed]

I've also noticed a lot of missing icons.
I am using Arch Linux, and CopyQ 3.5.0-1 from the AUR.
I have Font Awesome 5.1.1-1 installed.

But some are there:

[hluk]

Looks like the icons are just super tiny. The "New Tab" icon and others are created from an image, the tiny icons are create using Font Awesome.

Let me try to reproduce and fix it.

@scottkosty, @blueyed thanks for the detailed info, that's always appreciated.

[hluk]

I have no luck reproducing it.

What desktop environment do you use?

Can you provide output of env | grep '^QT_\|^GDK_'?

[scottkosty]

Thanks for trying to reproduce it, @hluk . I am using GNOME, the default desktop environment of Ubuntu 18.04. I get the following output of the command:

$ env | grep '^QT_\|^GDK_'
QT_ACCESSIBILITY=1
QT_IM_MODULE=ibus
$

[blueyed]

I am using awesomeWM as window manager, so no DE really, but I set DESKTOP_SESSION=gnome.

env | grep '^QT_\|^GDK_' is empty for me, but I start copyq using QT_SCALE_FACTOR=0.8 copyq & (to get the fonts smaller). But also without QT_SCALE_FACTOR it is the same.

% xrdb -q |grep dpi
*dpi:	175
Xft.dpi:	175

From xdpyinfo:

screen #0:
  dimensions:    1920x1080 pixels (278x156 millimeters)
  resolution:    175x176 dots per inch

[hluk]

Hmm, with QT_SCALE_FACTOR=0.8 copyq, the rendering is completely broken for me (Qt 5.10.1).

Are the icons bigger if you use QT_SCALE_FACTOR=1 copyq? You can also try setting QT_AUTO_SCREEN_SCALE_FACTOR=0.

[blueyed]

I am using Qt 5.11.1-1.
But QT_SCALE_FACTOR has no effect on this it seems (for me).

QT_SCALE_FACTOR=5 makes them more visible though, but it is hardly usable.. ;)

I was using QT_AUTO_SCREEN_SCALE_FACTOR=0 before, but read somewhere that it was deprecated. It helps for the font size, but not for the icons.

[blueyed]

btw: QT_SCALE_FACTOR=100 caused CopyQ to coredump, where the core file was truncated to 2GB then..!

[blueyed]

I am using version v3.5.0-58-g2d8622d5 currently.

[scottkosty]

btw: QT_SCALE_FACTOR=100 caused CopyQ to coredump

I see I'm not the only one that enjoys breaking things :). I tried this with another Qt app, LyX, and it also caused similar problems.

[hluk]

btw: QT_SCALE_FACTOR=100 caused CopyQ to coredump

QT_SCALE_FACTOR=100 causes Qt to request huge icons from CopyQ - this causes crash caused by DBUS of X11.

I'm implementing workaround, but people with 16k screens may complain in future about blurry icons. :)

[hluk]

Can you try to build and test CopyQ from branch scaling-fixes?

The fix is not to calculate maximum width for the icon font at runtime. I suspect that could cause the issue.

[scottkosty]

I tested with the scaling-fixes branch, and there are still buttons that do not look correct, but I see a lot of improvement to the right-side icons:

[hluk]

@scottkosty Can you try again?

I've updated the scaling-fixes branch so that the app uses font bundled with the application and not the font installed on system (this resolves some incompatibility issues).

[scottkosty]

@hluk just tried and it looks good! I've only tested briefly. Here is a new screenshot. From what I can tell, it looks good to me:

[blueyed]

@hluk
Looks good for me, too!

[hluk]

Cool, thanks for your cooperation! :)

This is fixed with 66176b2 (fixes icon size) and 62e883e (fixes missing icons).