Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect section background on Redesign pages #622

Closed
shirin27 opened this issue Feb 28, 2024 · 4 comments
Closed

Incorrect section background on Redesign pages #622

shirin27 opened this issue Feb 28, 2024 · 4 comments
Assignees
Labels

Comments

@shirin27
Copy link
Collaborator

From vg-macktrucks-com-rd created by cogniSyb: Netcentric#199

On redesign pages, the wrong background colour is used for sections marked with "black background"

Expected: Secondary/Graphite #1D1D1D
Result: Primary/Black #000000

See below that there’s a specificity issue in the CSS:
Screenshot 2024-01-11 at 13 15 36

@shirin27
Copy link
Collaborator Author

@DanielaPedrochevd Is this a bug? Please add milestone for this ticket.

@shirin27
Copy link
Collaborator Author

@cogniSyb the section metadata style that gives the graphite background color is dark-background

@shirin27
Copy link
Collaborator Author

Thanks @WendyKruger. Still that means a code change required to fix alignment issues:
Screenshot 2024-02-06 at 15 36 05

The margins are correct for a section with "black background" set. I’ll remove "black background" and will apply the right margins for "dark background"

@cogniSyb
Copy link
Collaborator

cogniSyb commented Mar 1, 2024

This bug will be addressed in #633.

The section modifier dark-background already existed. Applying colors worked differently before redesign, creating inconsistencies in front-end. Also, we had the section modifier black-background. Solution is to have (separate) consistent code for redesign pages with section modifiers black-background and graphite-background. This will be clearer for both editors and developers

@cogniSyb cogniSyb closed this as not planned Won't fix, can't repro, duplicate, stale Mar 1, 2024
@WendyKruger WendyKruger removed this from the MT PDP milestone Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants