Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using authentication through Subscriber #20

Open
mfontanini opened this issue Jun 29, 2015 · 5 comments
Open

Using authentication through Subscriber #20

mfontanini opened this issue Jun 29, 2015 · 5 comments

Comments

@mfontanini
Copy link

I'm trying to perform authentication via the AUTH command. This works just fine through Redox but I can't do the same for Subscriber since it doesn't allow command execution.

Are there any plans to add this? For now I just forked the code and added a getter for the internal Redox inside the subscriber but it would be really nice if the upstream codebase supported this. Especially since I don't think it's such an odd request to be able to authenticate before subscribing to channels.

I can create a PR for this, just let me know how you would like to achieve this (exposing the Redox might not be so nice)

@wegylexy
Copy link

Where is your fork with AUTH for Subscriber?

@mfontanini
Copy link
Author

I didn't even remember this. I probably have it somewhere in the company I work for's internal repos. I just moved over to using redis3m which has worked great, supports AUTH and never had an issue with it.

@wegylexy
Copy link

With C++17, I don't want boost for basic stuff. Sneaked into the Subscriber code of Redox, it's using commandLoop internally, so I just set the loop interval to numeric_limits<double>::infinity().
I still look forward to a more modern and performant interface.

@ingjieye
Copy link

ingjieye commented Aug 13, 2019

So I've checked subscriber.hpp. I think by expose rdx_ member from private to public. Then use it carefully would solve the issue.
Will create a PR soon with a more properly way to do the job.

@ingjieye
Copy link

So I've just create a PR to do the job in a more properly way.
#63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants