Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Rubyzip dependency to ~> 0.9.1 #25

Closed
wants to merge 1 commit into from
Closed

Set Rubyzip dependency to ~> 0.9.1 #25

wants to merge 1 commit into from

Conversation

holstvoogd
Copy link

rubyzip 1.0.0 breaks compatibility, stick 0.9.x versions.

rubyzip 1.0.0 breaks compatibility, stick 0.9.x versions.
@holstvoogd
Copy link
Author

It seems Rubyzip 1.0.0 was released today, so after a bundle update it was using it for the roo dependency, However, it turns out that it breaks it:

cannot load such file -- zip/zipfilesystem
.rvm/gems/ruby-1.9.3-p448/gems/roo-1.10.3/lib/roo/generic_spreadsheet.rb:5:in `<top (required)>'
.rvm/gems/ruby-1.9.3-p448/gems/roo-1.10.3/lib/roo/excelx.rb:14:in `<top (required)>'

@holstvoogd
Copy link
Author

I see now im on quite an old version of roo, let me see if the newer version works with 1.0.0 anyway.

@holstvoogd
Copy link
Author

ok 1.12.1 has the issue as well

@danfunk
Copy link

danfunk commented Sep 2, 2013

+1

@hmcgowan
Copy link
Collaborator

hmcgowan commented Sep 2, 2013

I'm no longer maintaining this gem but you can send your pull request to the current maintainer at https://github.com/Empact/roo

Thanks!
Hugh

@danfunk
Copy link

danfunk commented Sep 2, 2013

Hugh, we all owe you much thanks for your contributions. Found the repo, thank you for following up.

@holstvoogd holstvoogd closed this Jan 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants