This repository has been archived by the owner on Mar 2, 2021. It is now read-only.
Upload npm in pipeline #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Em-849 externalise JUI PDF annotator
phillipDenness
force-pushed
the
upload-npm-in-pipeline
branch
2 times, most recently
from
5eccd3c
to
f081b81
Compare
phillipDenness
force-pushed
the
upload-npm-in-pipeline
branch
from
f081b81
to
2d3955a
Compare
benouaer
force-pushed
the
upload-npm-in-pipeline
branch
from
42cf1e5
to
e0d8382
Compare
…oad-npm-in-pipeline
velimd
approved these changes
Jan 30, 2019
| /node_modules | ||
| node_modules/ | ||
| projects/annotation-ui-lib/node_modules/ | ||
| **/**/node_modules/ |
There was a problem hiding this comment.
question: why is this double -> **/ **/ , would **/node_modules/ work
There was a problem hiding this comment.
supposed to exclude node_modules for the library, under projects/annotation-ui-lib/node_modules
| - go to http://localhost:3000 and the viewer should load the document. | ||
|
|
||
| ### Building annotation library | ||
| - npm run package |
There was a problem hiding this comment.
as mentioned before, maybe best to have this before running
api/index.ts
Outdated
|
|
||
| if (config.configEnv !== 'prod') { | ||
| // Uncomment to enable direct access to Microservices | ||
| dmStoreApiRoutes(router) | ||
|
|
package.json
Outdated
| @@ -35,6 +40,7 @@ | |||
| "@angular/platform-browser-dynamic": "6.1.0", | |||
| "@angular/platform-server": "6.1.0", | |||
| "@angular/router": "6.1.0", | |||
| "@hmcts/annotation-ui-lib": "1.0.7-RC", | |||
There was a problem hiding this comment.
this need to be updated for the new version
added 8 commits
January 31, 2019 15:22
Codecov Report
@@ Coverage Diff @@
## master #6 +/- ##
=========================================
Coverage ? 90.62%
=========================================
Files ? 6
Lines ? 64
Branches ? 2
=========================================
Hits ? 58
Misses ? 4
Partials ? 2
Continue to review full report at Codecov.
|
added 12 commits
February 4, 2019 13:40
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.