Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email and password auth #76

Open
robbrad opened this issue May 18, 2024 · 2 comments
Open

Email and password auth #76

robbrad opened this issue May 18, 2024 · 2 comments

Comments

@robbrad
Copy link

robbrad commented May 18, 2024

What is needed to add email and password authentication

Issue I have found is it's possible to enter the same username again and it overwrites an existing account

@hmellor
Copy link
Owner

hmellor commented May 20, 2024

Issue I have found is it's possible to enter the same username again and it overwrites an existing account

This was actually intentional. It prevents a user from changing their display name and orphaning a bid they made with the old display name. i.e. bids are attached to UUIDs and the UUID is linked to whatever the user most recently set their display name to.

Originally, I didn't want email and password authentication because I didn't want to be handling personal information. But if you wanted to make a PR adding it as an option on the host side (i.e. the person hosting the website can choose which type of authentication they want to deploy, I'd accept that as a PR. I'd start here https://firebase.google.com/docs/auth/web/firebaseui

@robbrad
Copy link
Author

robbrad commented May 20, 2024

I have managed it and made quite a lot of code changes to the solution

Unfortunately I didn't make it optional. 🤦‍♂️

I'll submit a PR but more for reference.

I'm not at all used to firebase or JavaScript unfortunately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants