Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting lastDate w/out firstDate doesn't give the correct results #28

Closed
exts opened this issue Jul 12, 2020 · 2 comments · Fixed by #31
Closed

Setting lastDate w/out firstDate doesn't give the correct results #28

exts opened this issue Jul 12, 2020 · 2 comments · Fixed by #31
Labels
bug Something isn't working

Comments

@exts
Copy link

exts commented Jul 12, 2020

If initialDate is set to DateTime(2020, 7, 12) (july 2020) and lastDate is set to DateTime(2020,8) (august 2020) without setting firstDate the calendar won't show the year 2020 at all. It'll completely exclude 2020 as a year. Only when I set firstDate to 2 years ago then it properly excluded next month.
@hmkrivoj hmkrivoj added the bug Something isn't working label Jul 13, 2020
mono0926 added a commit to mono0926/month_picker_dialog that referenced this issue Sep 24, 2020
@mono0926
Fix Macacoazul01#28
1f3d414
@mono0926 mono0926 mentioned this issue Sep 24, 2020
Merged
@mono0926
Copy link
Contributor

mono0926 commented Sep 24, 2020 •
edited

Should have fixed by #31

@hmkrivoj hmkrivoj reopened this Sep 24, 2020
@hmkrivoj
Copy link
Collaborator

The fix provided by @mono0926 has been published as v0.3.3 to pub.dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix missing last yer when firstDate is null mono0926/month_picker_dialog
3 participants
@mono0926 @exts @hmkrivoj