The value of the HSV channel color is ignored during blending

[andreasg123]

Describe the bug
In blending channel colors, the assigned channel color is converted to HSV and then V is replaced by the intensity.

https://github.com/hms-dbmi/viv/blob/master/src/layers/XRLayer/shader-modules/channel-intensity.glsl#L78-L91

This removes the effect of assigning darker channel colors, e.g., rgb(0,128,0), to achieve a more perceptually uniform display.

To Reproduce
Change a channel color from rgb(0,255,0) to rgb(0,128,0). The resulting display does not change.

Expected behavior
The V component of the HSV color should be multiplied by the intensity clamped at 1. The resulting display should be darker if a darker channel color is assigned.

Screenshots
If applicable, add screenshots to help explain your problem.

Environment:

• Release or git hash: 0.10.3
• Browser: macOS Chrome
• Browser version: 92.0.4515.159

[ilan-gold]

@andreasg123 That makes sense, thanks for catching this. You're welcome to implement a fix, otherwise I will do it on Monday (or sooner) and ping you.

[andreasg123]

I can create a PR. However, I have to figure out first how to get around the issue that Next.js has with Viv 0.10.5: #303 (comment)