iOS: await FlutterDownloader.initialize(); leads to google sign in cancel button crash

[MunishThakur]

iOS Only:
After initializing await FlutterDownloader.initialize(); in main() when google sign in popup appears and user press cancel.. APP Crashes.

Please look into.

This is very basic to use google sign in. Many users will face the same.

[hnvn]

Try to modifying your AppDelegate like this:

@implementation AppDelegate

void registerPlugins(NSObject<FlutterPluginRegistry>* registry) {
  // [GeneratedPluginRegistrant registerWithRegistry:registry];
    [FlutterDownloaderPlugin registerWithRegistrar:[registry registrarForPlugin:@"vn.hunghd.flutter_downloader"]];
}

- (BOOL)application:(UIApplication *)application
    didFinishLaunchingWithOptions:(NSDictionary *)launchOptions {
  [GeneratedPluginRegistrant registerWithRegistry:self];
  [FlutterDownloaderPlugin setPluginRegistrantCallback:registerPlugins];
  // Override point for customization after application launch.
  return [super application:application didFinishLaunchingWithOptions:launchOptions];
}

[MunishThakur]

I have already modified AppDelegate like this and project running fine:

import UIKit
import Flutter
import Firebase
import flutter_downloader

@UIApplicationMain
@objc class AppDelegate: FlutterAppDelegate {
override func application(
_ application: UIApplication,
didFinishLaunchingWithOptions launchOptions: [UIApplicationLaunchOptionsKey: Any]?
) -> Bool {
GeneratedPluginRegistrant.register(with: self)
FlutterDownloaderPlugin.setPluginRegistrantCallback(registerPlugins)
if FirebaseApp.app() == nil {
FirebaseApp.configure()
}
return super.application(application, didFinishLaunchingWithOptions: launchOptions)
}
}

private func registerPlugins(registry: FlutterPluginRegistry) {
GeneratedPluginRegistrant.register(with: registry)
}

The main issue is google_sign_in popup (Cancel or success result) leads to crash. Something wrong with
await FlutterDownloader.initialize();

[MunishThakur]

Also in your documentation import flutter_downloader is missing. Please update doc

[hnvn]

Have a look at this comment. FlutterDownloader.initialize() will start a background isolate, the plugin needs to register itself with FlutterEngine in this step but it uses a special instance of FlutterEngine that is served for background execution only. The snip codes in AppDelegate serve for this special registration:

private func registerPlugins(registry: FlutterPluginRegistry) {
   GeneratedPluginRegistrant.register(with: registry)
}

This default codes will execute the registration of all plugins in your project and if there's any plugins that requires UI manipulation, they will be broken in this step.

[MunishThakur]

Thanks for the insight @hnvn. Issue is still the same. I just checked facebook login as well. When I click for facebook login It automatically lands to FacebookLoginStatus.cancelledByUser

This is really strange for me. No social login is working.

Without await FlutterDownloader.initialize(); works fine

[hnvn]

Check my first comment again and notice this snip codes:

void registerPlugins(NSObject<FlutterPluginRegistry>* registry) {
  // [GeneratedPluginRegistrant registerWithRegistry:registry];
    [FlutterDownloaderPlugin registerWithRegistrar:[registry registrarForPlugin:@"vn.hunghd.flutter_downloader"]];
}

It's a modified version (from default one in document) for your case. It's Objective-C codes, you may as well translate it to Swift in your case.

[MunishThakur]

Check my first comment again and notice this snip codes:

void registerPlugins(NSObject<FlutterPluginRegistry>* registry) {
  // [GeneratedPluginRegistrant registerWithRegistry:registry];
    [FlutterDownloaderPlugin registerWithRegistrar:[registry registrarForPlugin:@"vn.hunghd.flutter_downloader"]];
}

It's a modified version (from default one in document) for your case. It's Objective-C codes, you may as well translate it to Swift in your case.

Thanks swift version of above code worked for me. I already spent many hours, It saved many more :-)

Swift code:

private func registerPlugins(registry: FlutterPluginRegistry) {
//GeneratedPluginRegistrant.register(with: registry)
FlutterDownloaderPlugin.register(with: registry.registrar(forPlugin: "vn.hunghd.flutter_downloader"))
}

[hnvn]

Can you kindly share your full Swift codes of AppDelegate? I see the guys in this issue #149 still struggle with it.

[MunishThakur]

Complete AppDelegate swift code:

import UIKit
import Flutter
import Firebase
import flutter_downloader

@UIApplicationMain
@objc class AppDelegate: FlutterAppDelegate {
  override func application(
    _ application: UIApplication,
    didFinishLaunchingWithOptions launchOptions: [UIApplicationLaunchOptionsKey: Any]?
  ) -> Bool {
    GeneratedPluginRegistrant.register(with: self)
    FlutterDownloaderPlugin.setPluginRegistrantCallback(registerPlugins)
    if FirebaseApp.app() == nil {
        FirebaseApp.configure()
    }
    return super.application(application, didFinishLaunchingWithOptions: launchOptions)
  }
}

private func registerPlugins(registry: FlutterPluginRegistry) {
    //GeneratedPluginRegistrant.register(with: registry)
    FlutterDownloaderPlugin.register(with: registry.registrar(forPlugin: "vn.hunghd.flutter_downloader"))
}

[hnvn]

Nice

[thesmalleyes]

Complete AppDelegate swift code:

import UIKit
import Flutter
import Firebase
import flutter_downloader

@UIApplicationMain
@objc class AppDelegate: FlutterAppDelegate {
  override func application(
    _ application: UIApplication,
    didFinishLaunchingWithOptions launchOptions: [UIApplicationLaunchOptionsKey: Any]?
  ) -> Bool {
    GeneratedPluginRegistrant.register(with: self)
    FlutterDownloaderPlugin.setPluginRegistrantCallback(registerPlugins)
    if FirebaseApp.app() == nil {
        FirebaseApp.configure()
    }
    return super.application(application, didFinishLaunchingWithOptions: launchOptions)
  }
}

private func registerPlugins(registry: FlutterPluginRegistry) {
    //GeneratedPluginRegistrant.register(with: registry)
    FlutterDownloaderPlugin.register(with: registry.registrar(forPlugin: "vn.hunghd.flutter_downloader"))
}

i've tried to use this in my appdelegate.swift. Butt my app is still crash after launch

[MunishThakur]

Please share the log where it is crashing? My code was using facebook and some other libraries also which might be not necessary in your case.

Also Initialize it properly in main method.

[thesmalleyes]

this is my main method code

void main()async {
await FlutterDownloader.initialize();
// Pass all uncaught errors to Crashlytics.
FlutterError.onError = Crashlytics.instance.recordFlutterError;
runZoned<Future>(() async {
runApp();
}, onError: Crashlytics.instance.recordError);
}

i only got this message :

Crashlytics:Crash] Warning: NSUncaughtExceptionHandler is 'FBSDKExceptionHandler' in '/Users/bayuramadeza/Library/Developer/CoreSimulator/Devices/44000030-2E22-42F6-BF42-CC931D5BA3C9/data/Containers/Bundle/Application/F05047C6-5ECA-4EF8-BB38-A004FAE40411/Runner.app/Frameworks/FBSDKCoreKit.framework/FBSDKCoreKit'
[C7.1 68865C5A-3DC9-44D2-97CF-E68DAF006D64 192.168.1.12:61453<->157.240.13.14:443]
Connected Path: satisfied (Path is satisfied), interface: en0
Duration: 0.537s, DNS @0.002s took 0.002s, TCP @0.005s took 0.021s, TLS took 0.034s
bytes in/out: 4370/1559, packets in/out: 9/9, rtt: 0.024s, retransmitted packets: 0, out-of-order packets: 0
Lost connection to device.
Exited (sigterm)

[MunishThakur]

"FBSDKExceptionHandler" is related with Facebook SDK. You must be sure if you have added FB sdk or if your app do not use FB SDK. Just remove FB related instances from your project.

firebase/quickstart-unity#486

Might help.

[thesmalleyes]

But, it’s running well if i don’t use flutter downloader,

[erperejildo]

Sorry, what's the solution here? I have the same issue