Some correctness issues and handle leaks

[JohnLaTwC]

Issue 1

GetProcId does not close process snapshot in early return

DWORD GetProcId(const wchar_t* ProcName)
{
	PROCESSENTRY32   pe32;
	HANDLE         hSnapshot = NULL;

	pe32.dwSize = sizeof(PROCESSENTRY32);
	hSnapshot = CreateToolhelp32Snapshot(TH32CS_SNAPPROCESS, 0);

	if (Process32First(hSnapshot, &pe32))
	{
		do {
			if (wcscmp(pe32.szExeFile, ProcName) == 0) {
+				CloseHandle(hSnapshot);
				return pe32.th32ProcessID;
				break;
			}

		} while (Process32Next(hSnapshot, &pe32));
	}
	if (hSnapshot != INVALID_HANDLE_VALUE)
		CloseHandle(hSnapshot);

	return NULL;
}

AndrewSpecial/AndrewSpecial.cpp

Line 15 in 81f7cdb

return pe32.th32ProcessID;

Issue 2

Incorrect check on CreateFile API

		HANDLE hFile = CreateFileA("Andrew.dmp", GENERIC_ALL, 0, nullptr, CREATE_ALWAYS, FILE_ATTRIBUTE_NORMAL, nullptr); //Create the dmp file

		if (!hFile)
! This check is incorrect. If CreateFileA fails, hFile will be INVALID_HANDLE_VALUE which is -1 not 0.
		{
			printf("Failed to write dump: Invalid dump file\n");
		}

AndrewSpecial/AndrewSpecial.cpp

Line 154 in 81f7cdb

if (!hFile)

Issue 3

AndrewSpecial should call CloseHandle on hProc to avoid a handle leak. There are a couple of code paths that exit the function without closing the handle.

AndrewSpecial/AndrewSpecial.cpp

Line 181 in 81f7cdb

return 0;

AndrewSpecial/AndrewSpecial.cpp

Line 194 in 81f7cdb

return 1;

AndrewSpecial/AndrewSpecial.cpp

Line 181 in 81f7cdb

return 0;