Skip to content
This repository has been archived by the owner on Sep 20, 2021. It is now read-only.

Do not deploy bin/console #12

Closed
jubianchi opened this issue Jan 5, 2015 · 5 comments
Closed

Do not deploy bin/console #12

jubianchi opened this issue Jan 5, 2015 · 5 comments

Comments

@jubianchi
Copy link
Member

THe file bin/console is only used for test purpose: it should not be part of the delivered code. We should remove the bin-dir configuration from the composer.json file so that the file is not deployed when users require this library

@mickaelandrieu
Copy link

you can play with Composer events to create the file console in bin dir, if devMode == true.

What do you think ? I can make a pr tomorrow :)

@jubianchi
Copy link
Member Author

@mickaelandrieu thanks but I don't think we should spend too much time on this one: to me, this file will only be really required when working on the library itself. It will be rarely used in other context, I think.

What I propose is simple to drop this file. This will never get linked in top-level package/applications bin directory.
The name of the binary is also too generic. It could easily create conflict with something else.

I'm also thinking of removing much more from dist. archives using a .gitattributes (exclude bin/console, tests, .travis.yml, ...).

Thoughts @hoaproject/hoackers ?

@Hywan
Copy link
Member

Hywan commented Jan 5, 2015

@jubianchi 👍 for dropping it. However, how to test then?

@jubianchi
Copy link
Member Author

@Hywan the file will not be drpped just ignored from a composer/dist point of view.

@Hywan
Copy link
Member

Hywan commented Jan 6, 2015

@jubianchi Yup, realized this after.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

3 participants