-
Notifications
You must be signed in to change notification settings - Fork 4
Do not deploy bin/console
#12
Comments
you can play with Composer events to create the file console in bin dir, if devMode == true. What do you think ? I can make a pr tomorrow :) |
@mickaelandrieu thanks but I don't think we should spend too much time on this one: to me, this file will only be really required when working on the library itself. It will be rarely used in other context, I think. What I propose is simple to drop this file. This will never get linked in top-level package/applications bin directory. I'm also thinking of removing much more from dist. archives using a Thoughts @hoaproject/hoackers ? |
@jubianchi 👍 for dropping it. However, how to test then? |
@Hywan the file will not be drpped just ignored from a composer/dist point of view. |
@jubianchi Yup, realized this after. |
THe file
bin/console
is only used for test purpose: it should not be part of the delivered code. We should remove thebin-dir
configuration from thecomposer.json
file so that the file is not deployed when users require this libraryThe text was updated successfully, but these errors were encountered: