Query string parameters seem unsupported?

[pietervogelaar]

It seems that query string parameters are unsupported. If I have a websocket URL like:

wss://br3-teapot.br.de/socket.io/?EIO=3&transport=websocket

I get an error

Handshake has failed, the server did not return a valid response.

Client:
    GET /socket.io/ HTTP/1.1
    ...

The query string is not in the HTTP request, but it is required. For example, if I test it on http://www.websocket.org/echo.html it works just fine with the complete url but not when the query string part is stripped.

This is a part of my code at the moment:

$socketClient = new SocketClient($url);
$webSocketClient = new WebSocketClient($socketClient);

What can I do to make this work?

[Hywan]

Hello :-),

Good idea and thank you for the feature request. I reckon you can try a PR by yourself (if you want to!). The ws:// and wss:// URI are transformed into tcp:// and the line you might want to change could be

Websocket/Socket.php

Line 121 in ad7b390

isset($parsed['path']) ? $parsed['path'] : '/'

. Do you want to try a PR?

[Hywan]

Without no answer from your end, I decided to make a PR 😃. The review should start very quickly and the merge will happen as fast as possible because this is a bug fix.

[Hywan]

A new snapshot has been released: https://github.com/hoaproject/Websocket/releases/tag/3.16.05.09. Thanks!