reorganize tests in t_sub #1116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test models please |
|
test models please |
|
Turbofan has a really strange error that is causing the model failure. This is the same failure in the turbofan_Push tests. |
|
ok, merging since this is approved and is not contributing any new failures on model tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bqpd ready for review. This PR consists only of renaming
TestGPSubs-->TestModelSubs, reordering (moved some methods fromTestNomialSubstoTestModelSubs), and a docstring fix.Anyone else: feel free to add to this PR if there is any other obvious test reorganization that's low-hanging.