Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can the limit on number of transmitter sites be eliminated? #42

Open
KyleMaas opened this issue Jul 30, 2024 · 1 comment · May be fixed by #45
Open

Can the limit on number of transmitter sites be eliminated? #42

KyleMaas opened this issue Jul 30, 2024 · 1 comment · May be fixed by #45

Comments

@KyleMaas
Copy link

I'd like to be able to run coverage studies with more than 30 transmitter sites. Is there a reason why the 30 transmitter limit is still necessary now that computers have larger RAM?

splat/src/main.cpp

Line 125 in c9c3939

" -t txsite(s).qth (max of 4 with -c, max of 30 with -L)\n"

splat/src/main.cpp

Line 450 in c9c3939

while (z <= y && argv[z][0] && argv[z][0] != '-' && tx_site.size() < 30) {

The documentation says it's supposed to be 4 for coverage map studies, but that no longer seems to be enforced now that this line is no longer there:

https://github.com/jmcmellen/splat/blob/08f06f56470a8361a5609503a6b1cb02f07f48dc/splat.cpp#L8032

Either way, the 30 site limit seems kind of arbitrary, and if I'd think if I'm individually passing QTH files to it on the command line, that as a user, if I specify a lot of them it takes a long time to calculate, it comes with the territory.
@KyleMaas KyleMaas linked a pull request Jul 31, 2024 that will close this issue
Open
@hoche
Copy link
Owner

hoche commented Aug 1, 2024

Yeah, this is silly these days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove seemingly arbitrary 30-site limit on transmitters KyleMaas/splat
2 participants
@KyleMaas @hoche