Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apps don't respect theme #75

Open
hockeymikey opened this issue Aug 1, 2022 · 2 comments
Open

Apps don't respect theme #75

hockeymikey opened this issue Aug 1, 2022 · 2 comments

Comments

@hockeymikey
Copy link
Owner

For some reason: https://github.com/thundernest/k-9/blob/9f25f27066d94fb6647c47b1c4f6913305294afd/app/ui/base/src/main/java/com/fsck/k9/ui/base/ThemeManager.kt

Seems apps check for sdk 29 before checking our theme. Don't know why, sdk 8 is when it was introduced. Maybe have to bump to 29 and spoof it?

@SkewedZeppelin
Copy link

Dark theme in 8.0 was an experimental feature that most aftermarket systems made available. It wasn't official until 9.0.
Not much to really to handle this without breaking things or maybe (ab)using RROs.

Best solution is probably just to ask the app devs to lower the check if possible. I did so for Briar for example.

@hockeymikey
Copy link
Owner Author

@SkewedZeppelin Drats, I was afraid of that. Guess I'll have to explore this more then. There are some like k-9 that I know would probably check lower, but others like say Teams, definitely are lost causes and need that heavy handed approach on the OS side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants