Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not check error message #39

Closed
hofnerb opened this issue Sep 11, 2018 · 0 comments
Closed

Do not check error message #39

hofnerb opened this issue Sep 11, 2018 · 0 comments

Comments

@hofnerb
Copy link
Owner

hofnerb commented Sep 11, 2018

Test does not adhere to the guidance given in https://cran.r-project.org/doc/manuals/r-release/R-exts.html#Writing-portable-packages:

Do not test the exact format of R messages (from R itself or from other
packages): They change, and they can be translated.

Packages have even tested the exact format of system error messages, which are platform-dependent and perhaps locale-dependent.

and thus results in an error:

 ── 1. Failure: write.bib (@test-toLatex.R#105) ────────────────────────────────
 `write.bib("nonexisting_pkg")` threw an error with unexpected message.
 Expected match: "package .* not found"
 Actual message: "there is no package called 'nonexisting_pkg'"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant