Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unrecognised OSWORD A=08 service call bug #8

Open
hoglet67 opened this issue Feb 5, 2018 · 4 comments
Open

Unrecognised OSWORD A=08 service call bug #8

hoglet67 opened this issue Feb 5, 2018 · 4 comments
Labels

Comments

@hoglet67
Copy link
Owner

hoglet67 commented Feb 5, 2018

When MMFS is not the current file system, this service call is claimed rather than passed on.

See:
http://www.stardot.org.uk/forums/viewtopic.php?p=193394#p193394

Dave

@hoglet67 hoglet67 added the bug label Jul 1, 2021
@SteveFosdick
Copy link

There appear to be two separate underlying bugs here:

  1. In the OSWORD code the check for whether MMFS is the current filing system and setting the return status of the service call as A=00 are done in the wrong order.
  2. In FSisMMFS, testing the file minimum file handle does not test is MMFS is the current FS as MMFS uses the same file handles as DFS so this returns true even if DFS is the current FS.

I have a version that fixed both of these - see: SteveFosdick@5bba36f though I can't see immediately how to turn that into a pull request.

@hoglet67
Copy link
Owner Author

hoglet67 commented Oct 16, 2021

Thanks Steve,

I can pull the commit in directly and merge it.

Dave

@SteveFosdick
Copy link

SteveFosdick commented Oct 16, 2021

And a version of the test program:

   10osword=&FFF1
   20PROCrunosw("DISC")
   30PROCrunosw("CARD")
   40PROCrunosw("DISC")
   50PROCrunosw("CARD")
   60END
   70DEFPROCrunosw(F$)
   80OSCLI F$
   90A%=&7E
  100X%=&70
  110Y%=0
  120CALLosword
  130N%=(!&71 AND &FFFF)DIV10
  140PRINTF$;": Number of tracks ";N%
  150ENDPROC

@hoglet67
Copy link
Owner Author

Fix included in MMFS 1.54.

See further discussion here:
https://stardot.org.uk/forums/viewtopic.php?p=390229#p390229

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants