New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addition of sound sources can overflow #2

Open

BigEd opened this issue Mar 2, 2017 · 0 comments

BigEd commented Mar 2, 2017

The various sound sources should go into a saturating adder, probably - or something more sophisticated - should not overflow.

The code presently just adds the sound chip, the SID, the disk drive sample and the Music 5000, without headroom and without regard for overflow. See

BeebFpga/src/common/bbc_micro_core.vhd

Line 995 in 1a6c95e

variable l : std_logic_vector(15 downto 0);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment