Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Items not handled correctly with option Rollback::First. #52

Closed
Kered13 opened this issue Feb 2, 2023 · 1 comment
Closed

Items not handled correctly with option Rollback::First. #52

Kered13 opened this issue Feb 2, 2023 · 1 comment

Comments

@Kered13
Copy link

Kered13 commented Feb 2, 2023

When a rollback frame comes in with an item event, that item event will be appended to the vector of items for that frame, when it should be ignored because it is a rollback frame.

Items are appended here. Notice that there is no check for the Rollback::First option, and no check if the item is part of a rollback frame or an original frame.

@hohav
Copy link
Owner

hohav commented Jan 3, 2024

No longer an issue in latest main, because parsing no longer treats rollback frames specially. You'd instead use the new deduped_validity to iterate over only initial or final rollback frames.

@hohav hohav closed this as completed Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants