Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The constructor accepts options that are not documented #41

Open
smoyer64 opened this issue Apr 4, 2022 · 1 comment
Open

The constructor accepts options that are not documented #41

smoyer64 opened this issue Apr 4, 2022 · 1 comment

Comments

@smoyer64
Copy link

smoyer64 commented Apr 4, 2022

The ephemeral, adaptive, id and concurrency values are processed as options to the dht-rpc constructor but are not included in the documented options (https://github.com/mafintosh/dht-rpc#const-node--new-dhtoptions).

@mafintosh
Copy link
Contributor

ephemeral and adaptive are described there, in the paragraph. In reality you should never really mess with those, and people kept getting confused, hence why there aren't prominent.

For id, we should just remove that, it's if you somehow know the id it'll pick, mostly just internal.

concurrency should be on the list tho for sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants