Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about the next release #56

Closed
kilimandzsaro opened this issue Jul 3, 2017 · 11 comments
Closed

Question about the next release #56

kilimandzsaro opened this issue Jul 3, 2017 · 11 comments
Assignees

Comments

@kilimandzsaro
Copy link
Contributor

Hi, I just want to ask when do you plan the next release?

@ttwo32
Copy link
Member

ttwo32 commented Jul 3, 2017

Hi @kilimandzsaro.
I'm sorry for the delay.
I plan the next release at this weekend.
Could you wait until this weekend?
Thanks.

@ppeble
Copy link
Member

ppeble commented Jul 3, 2017

I apologize for my tardiness around merges and releases. Having a 6 month old is killing my free time. 😦

I will do a release either today or tomorrow that will include all of the recent updates. Thanks for your patience!

@spaceneedle2019
Copy link
Contributor

@ppeble

Having a 6 month old is killing my free time.

No problem. Keep going! And welcome to family life. :)

@kilimandzsaro
Copy link
Contributor Author

No problem at all, I just wanted to know when can I count on it :) @ppeble have fun with your new family member.

@ppeble
Copy link
Member

ppeble commented Jul 13, 2017

I'm awful, sorry. But I am at a conference this week (gophercon!) so I will have free time between talks and in the evenings and so I promise a release will go out before Friday. Thank you again for being so nice and understanding and thank you to @ttwo32 for carrying the load while I adjust to my new life schedule.

@ppeble ppeble self-assigned this Jul 13, 2017
@ppeble
Copy link
Member

ppeble commented Jul 14, 2017

Okay! FINALLY FINALLY FINALLY

FINALLY

holidays/holidays#281

It's everything that has been done in since v5.6.0. That PR is just a formality, once everything passes and @ttwo32 gives it a once-over I'll merge, build, and then publish the gem.

@ppeble
Copy link
Member

ppeble commented Jul 16, 2017

Thank you again. v5.7.0 is out on rubygems.org with the latest definitions. Please let me know if anything looks amiss.

@ppeble ppeble closed this as completed Jul 16, 2017
@spaceneedle2019
Copy link
Contributor

Thank you. Very cool, so I can finally remove the temporary custom calendars from our application. I'll try it upcoming week. :)

@ppeble
Copy link
Member

ppeble commented Jul 16, 2017

Yes! And thanks again. Everyone has been so nice to me, even though I constantly blew past the commitments that I set for myself. Thank you thank you thank you. ❤️

@ppeble
Copy link
Member

ppeble commented Jul 16, 2017

Oh and @spaceneedle2019, since you've updated so many definitions, this will probably affect you more than most. Please note the changes in this PR: #26

Here is the issue where I lay out the details of what I did: #7

Long story short, I want to switch how the tests are written, away from pure ruby. I'm not going to accept any more PRs until I merge the linked one since trying to keep it up to date has been a nightmare. I'm about 97% done with the changes required to the ruby side to make this all work and in the end it should work identically. Only how we generate tests changes. But I want you to be aware so that you don't spend a lot of time updating tests in ruby and then have to switch the format. If you want to talk more about the specifics you can hit me up on twitter (https://twitter.com/philpeble) or we can talk on slack or email or whatever. Just let me know!

@spaceneedle2019
Copy link
Contributor

You're very welcome, @ppeble. 😃

I already noticed that you guys want to change the way to writing tests for the definitions. Sounds like a good thing, there is no doubt about it. I'll keep an eye on it and remain in the background for now. :)

P.S.: Some moments ago I've added you on Twitter. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants