Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intersection max_xy calculation correct? #17

Closed
kapsyst opened this issue Jun 28, 2023 · 1 comment
Closed

Intersection max_xy calculation correct? #17

kapsyst opened this issue Jun 28, 2023 · 1 comment

Comments

@kapsyst
Copy link

kapsyst commented Jun 28, 2023

max_xy = torch.min(box_a[:, 2:].unsqueeze(1).expand(A, B, 2),

I may be reading it wrong, but are the lines used to calculate max_xy using the box dimensions, when they should be using the boxes max x/y coordinates?

A box is defined as [min_x, min_y, dim_x, dim_y], is it not?

@kapsyst
Copy link
Author

kapsyst commented Jun 28, 2023

My bad, I was confusing decoded boxes with raw boxes:

boxes[..., 2] = y_center + h / 2. # ymax

Makes sense now!

@kapsyst kapsyst closed this as completed Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant