Breaking: Upgrade TS deps, enable ESLint for TS files (#91)

* Breaking: Upgrade TS deps, enable ESLint for TS files * Other: Prefix some overrides with c__
hollowverse-archive · Jun 27, 2018 · 638294c · 638294c
1 parent 0cb39f2
commit 638294c
Show file tree

Hide file tree

Showing 7 changed files with 19 additions and 13 deletions.
diff --git a/clown/common/validateFilenames.json b/clown/common/validateFilenames.json
@@ -18,7 +18,8 @@
         "**/docker-compose.yml",
         "**/Dockerfile*",
         "**/LICENSE",
-        "**/README.md"
+        "**/README.md",
+        "**/clownOverrides/c__*"
       ]
     }
   ]

diff --git a/clown/typescript/package.json b/clown/typescript/package.json
@@ -1,17 +1,20 @@
 {
   "scripts": {
     "check-ts": "tsc --project . --noEmit",
-    "lint-ts": "tslint 'src/**/*.ts' --project ."
+    "lint-ts/eslint": "eslint '**/*.ts{,x}'",
+    "lint-ts/tslint": "tslint '**/*.ts{,x}' --project .  --exclude '**/node_modules/**' --exclude '**/.serverless/**'  --exclude '**/.webpack/**'  --exclude '**/dist/**'",
+    "lint-ts": "run-p -c --aggregate-output 'lint-ts/*'"
   },
   "devDependencies": {
-    "eslint-plugin-typescript": "^0.11.0",
-    "typescript": "^2.8.1",
+    "eslint-plugin-typescript": "^0.12.0",
+    "typescript": "^2.9.2",
     "tslint-language-service": "^0.9.9",
-    "tslint": "^5.9.1",
+    "tslint": "^5.10.0",
     "tslint-config-prettier": "^1.8.0",
-    "tslint-eslint-rules": "^5.0.0",
+    "tslint-eslint-rules": "^5.3.1",
     "tslint-microsoft-contrib": "^5.0.3",
-    "tslint-react": "^3.5.1",
-    "typescript-eslint-parser": "^15.0.0"
+    "tslint-react": "^3.6.0",
+    "typescript-eslint-parser": "^16.0.0",
+    "npm-run-all": "^4.1.3"
   }
 }
diff --git a/clownOverrides/.eslintrc.json → clownOverrides/c__.eslintrc.json b/clownOverrides/.eslintrc.json → clownOverrides/c__.eslintrc.json
diff --git a/clownOverrides/.npmignore → clownOverrides/c__.npmignore b/clownOverrides/.npmignore → clownOverrides/c__.npmignore
diff --git a/clownOverrides/package.json → clownOverrides/c__package.json b/clownOverrides/package.json → clownOverrides/c__package.json
@@ -6,8 +6,6 @@
     "build": "exit 0"
   },
   "lint-staged": {
-    "**/*.js{x,}": [
-      "eslint -c .eslintrc.json --no-eslintrc"
-    ]
+    "**/*.js{x,}": ["eslint -c .eslintrc.json --no-eslintrc"]
   }
-}
+}
diff --git a/eslint/typescript/.eslintrc.json b/eslint/typescript/.eslintrc.json
@@ -14,6 +14,9 @@
     "no-unexpected-require": ["off"],
     "import/first": ["off"],
 
+    // Buggy for TS, see https://github.com/eslint/typescript-eslint-parser/issues/384
+    "no-useless-constructor": ["off"],
+
     // Already handled by TSLint
 
     "import/no-dynamic-require": ["off"],

diff --git a/validateFilenames.json b/validateFilenames.json
@@ -18,7 +18,8 @@
         "**/docker-compose.yml",
         "**/Dockerfile*",
         "**/LICENSE",
-        "**/README.md"
+        "**/README.md",
+        "**/clownOverrides/c__*"
       ]
     }
   ]