Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration with oh-my-zsh #70

Closed
jrhorn424 opened this issue Feb 18, 2013 · 8 comments · May be fixed by #272
Closed

Integration with oh-my-zsh #70

jrhorn424 opened this issue Feb 18, 2013 · 8 comments · May be fixed by #272

Comments

@jrhorn424
Copy link

Anyone have any clever ideas for including oh-my-zsh in dotfiles? I gave up after a few hours last night once I realized dotfiles was loading every single plugin in the oh-my-zsh tree, since they all end in .zsh. Maybe I should just define a different extension for sourcing?

@holman
Copy link
Owner

holman commented Feb 18, 2013

That'd be the approach I'd take, probably. I haven't played around with oh-my-zsh in particular, myself, but you could probably be more specific about what you'd like to source.

Closing this out since it's not an issue per se, but definitely feel free to continue to discuss this here. :)

@holman holman closed this as completed Feb 18, 2013
@jrhorn424
Copy link
Author

Thanks, definitely not an issue. I have a bad habit of treating the issue tracker as a project forum. Thanks for the reply. I'll give this some more thought and link a pull request/patch if I do anything. In the meantime, I'd be interested to hear what others have to say. There was astoundingly little in a Google search on this, but then again googling "dotfiles" isn't fun.

@memborsky
Copy link
Contributor

Depending on which is smaller, you can make an include/exclude list of which plugins you want/don't want in oh-my-zsh. On line 17-21 of zshrc is where the magic happens. You'll want to manage the exclude/include at this point to parse out which of the oh-my-zsh plugins you want to include/exclude.

@gaboesquivel
Copy link

from http://aniketpant.com/2013/04/get-your-dotfiles-straight/

"I had to make some changes for Holman's dotfiles to work for me. The major problem I faced was the fact that I use oh-my-zsh and it has it's own set of features to take care of. And then, Holman's dotfiles work from the your cloned repo. To fix it, I changed one variable and introduced my own. $ZSH was changed to $ZSHDOT everywhere and I changed $ZSH to point to .oh-my-zsh and everything became peaceful."

--> https://github.com/aniketpant/dotfiles/blob/master/zsh/config.zsh

@thomaswelton
Copy link

Thanks @gaboesquivel

@joech4n
Copy link

joech4n commented Jan 24, 2015

Both the @holman dotfiles and oh-my-zsh seem to use the $ZSH env variable.

Maybe setting the var before any oh-my-zsh commands?

ZSH=~/.oh-my-zsh upgrade_oh_my_zsh

@wackywendell
Copy link
Contributor

I think it makes sense for both projects to not name it $ZSH, but something more specific: $ZSHDOT here, and maybe $OMZSH there. What do others think? Should I submit a PR?

@j-walker23
Copy link

That makes sense to me. I was surprised to see the variable named like that for two separate systems. Wondered if it was some convention i didn't understand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants