Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work with holochain v0.3.0-beta-dev.23 #211

Closed
guillemcordoba opened this issue Nov 8, 2023 · 2 comments
Closed

Does not work with holochain v0.3.0-beta-dev.23 #211

guillemcordoba opened this issue Nov 8, 2023 · 2 comments

Comments

@guillemcordoba
Copy link
Contributor

While trying to upgrade to that version of holochain, @holochain/client stops working altogether. Any call that it tries to make, results in this kind of error being returned:

{
  type: { deserialization: null },
  data: 'Bytes(Deserialize("wrong msgpack marker FixStr(11)"))'
}

This happens with the AdminInterface as well as with the AppInterface.

Maybe this is not an issue with the client... I've spent a lot of time exploring its causes with no result. I did find this issue, and also noticed that now the holochain git repository depends on two versions of rmp-serde, 0.15 and 1.1 - maybe that's the cause? But I don't think so because I was able to run sweettests without problems.

Maybe this PR was the one that introduced the problem? holochain/holochain#2844

@jost-s
Copy link
Contributor

jost-s commented Nov 9, 2023

Yes, the ser/de changed somehow. I'll release a matching client for the time being and look into reverting this change on the Holochain side. It's not for the better IMO, from

{
  type: "error",
  data: ...
}

to

  type: { error: null },
  data: ...
}

@jost-s
Copy link
Contributor

jost-s commented Nov 9, 2023

fixed by #212
tryorama release to follow

@jost-s jost-s closed this as completed Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants