Skip to content
This repository has been archived by the owner on Feb 3, 2023. It is now read-only.

HDK Proc Macro package name #1791

Open
StaticallyTypedAnxiety opened this issue Oct 22, 2019 · 2 comments
Open

HDK Proc Macro package name #1791

StaticallyTypedAnxiety opened this issue Oct 22, 2019 · 2 comments

Comments

@StaticallyTypedAnxiety
Copy link
Contributor

As we spoke last week, we have yet to come up with a resolution to the issue of the hdk proc macro package name. As we have it, the proc macro hdk is named hdk_proc_macro but since we are moving towards publishing it to crates.io we need o decide on the naming scheme. Should this be changed to hdk_v2 or should we keep it as hdk_proc_macro.

The benefits of hdk_proc_macro are that developers won't have to change the name in their toml however, the naming scheme is a bit weird as compared to hdk_v2

@willemolding
Copy link
Collaborator

As an alternative we could merge #1645 before we do the crates.io release and just pretend the original HDK never happened?

@willemolding
Copy link
Collaborator

willemolding commented Nov 1, 2019

I've just realized this isn't really possible in current Rust. Proc macro crates can only export proc macros so it is impossible to have a single HDK crate. This kinda sucks I think

For this reason though I argue strongly against hdk_v2 since consumers will always need both crates. Eventually we can just remove the old macros from the hdk crate

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants