Skip to content
This repository has been archived by the owner on Feb 3, 2023. It is now read-only.

use collection that allows more efficient get() in source chain #50

Closed
thedavidmeister opened this issue Jun 26, 2018 · 4 comments
Closed

Comments

@thedavidmeister
Copy link
Contributor

current get implementation is slow as it iterates through the whole chain with a filter to implement get.

similar to #35 this is simply due to running everything through a single vector and could be improved by leveraging additional data structures internally

@sphinxc0re
Copy link
Contributor

There is BTreeMap and also HashMap. Are you suggesting one of those?

@thedavidmeister
Copy link
Contributor Author

@sphinxc0re yes, see the related issues for further discussion

should be able to just have a hash map of pairs based on a custom hashing algo that exposes the header hash as keys + a single top pair

iterator can be built from this to have an index pair

@jamesray1
Copy link
Contributor

jamesray1 commented Nov 27, 2019

[F7-optimization][P7-nicetohave]

@thedavidmeister
Copy link
Contributor Author

chains are now implemented by whatever persistence backend is configured in the conductor

speed optimisations (e.g. indexing) are up to whatever the storage mechanism can do

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants