Skip to content
This repository has been archived by the owner on Feb 3, 2023. It is now read-only.

holochain_net: configure log level #1085

Merged
merged 13 commits into from Mar 6, 2019
Merged

holochain_net: configure log level #1085

merged 13 commits into from Mar 6, 2019

Conversation

ddd-mtl
Copy link
Contributor

@ddd-mtl ddd-mtl commented Mar 5, 2019

  • I have added a summary of my changes to the changelog

HC_N3H_LOG_LEVEL

Set the logging level used globally by N3H. Must be one of the following: 't', 'd', 'i', 'w', 'e'

Misc

Made tweetlogging macros available within the 'net' crate.

@ddd-mtl ddd-mtl added the review label Mar 5, 2019
@ddd-mtl ddd-mtl changed the title WIP - holochain_net: configure log level holochain_net: configure log level Mar 5, 2019
@ddd-mtl ddd-mtl marked this pull request as ready for review March 5, 2019 20:44
CHANGELOG.md Outdated Show resolved Hide resolved
Connoropolous and others added 2 commits March 5, 2019 17:40
Co-Authored-By: ddd-mtl <34140573+ddd-mtl@users.noreply.github.com>
Copy link
Contributor

@neonphog neonphog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 lgtm

@Connoropolous
Copy link
Collaborator

So let me get this straight, N3H_LOG_LEVEL is actually for n3h, then there is a SEPARATE env var for HC that controls that ENV var?

Copy link
Collaborator

@Connoropolous Connoropolous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add somewhere here what the different log level initials stand for / are / do?

@ddd-mtl
Copy link
Contributor Author

ddd-mtl commented Mar 6, 2019

@Connoropolous Yes, and Done :)

@ddd-mtl ddd-mtl merged commit 18bb459 into develop Mar 6, 2019
@ddd-mtl ddd-mtl removed the review label Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants