Skip to content
This repository has been archived by the owner on Feb 3, 2023. It is now read-only.

0.0.6 merge: Don't hang up tests on SyntaxError #1091

Merged
merged 5 commits into from Mar 7, 2019
Merged

0.0.6 merge: Don't hang up tests on SyntaxError #1091

merged 5 commits into from Mar 7, 2019

Conversation

maackle
Copy link
Member

@maackle maackle commented Mar 7, 2019

  • I have added a summary of my changes to the changelog

zippy
zippy reviewed Mar 7, 2019
View reviewed changes
Copy link
Member

@zippy zippy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to approve this but the failing app-spec test makes me worried. Any Idea what's going on?

@maackle
Copy link
Member Author

maackle commented Mar 7, 2019

Yep, this is a real problem. Stay tuned...

@Connoropolous Connoropolous merged commit 2a0bbf7 into develop Mar 7, 2019
@Connoropolous Connoropolous changed the title Don't hang up tests on SyntaxError 0.0.6 merge: Don't hang up tests on SyntaxError Mar 7, 2019
@zippy zippy deleted the nodejs-tests-less-freezy branch July 5, 2019 13:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zippy zippy zippy approved these changes

@lucksus lucksus lucksus approved these changes

@Connoropolous Connoropolous Connoropolous approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@maackle @zippy @lucksus @Connoropolous