n3h mode default to REAL

[lucksus]

PR summary

As discussed with @ddd-mtl, the n3h mode to use as default should be REAL now.

changelog

Please check one of the following, relating to the CHANGELOG

• this is a code change that effects some consumer (e.g. zome developers) of holochain core so there is an 'Unreleased' CHANGELOG item, with the format - summary of change [PR#1234](https://github.com/holochain/holochain-rust/pull/1234)
• this is not a code change, or doesn't effect anyone outside holochain core development

[neonphog]

👍

[Connoropolous]

Could we take this opportunity to clarify internally and externally what these modes actually are? I personally don’t even know, in clear terms

[ddd-mtl]

REAL is a big update to HACK mode.
HACK is going to dissapear shortly.
Consider REAL to be HACK mode's new name.
I needed to keep both around to make sure things didn't break.

REAL is in opposition to MOCK mode.
Mock mode is where you connect multiple local nodes to one n3h in order to simulate a network over IPC.
REAL is the normal n3h mode that gossips over the network.
Maybe renamed it to NORMAL?

Is that clear enough for you?

[Connoropolous]

Yep

[thedavidmeister]

@Connoropolous @ddd-mtl can it be a small followup to do a rename and document this?

[thedavidmeister]

document values now or later/followup?

[lucksus]

@ddd-mtl, is this correct?
@Connoropolous, is this sufficient?

[ddd-mtl]

Yes, except for HACK. I'd write:

/// HACK - Deprecated. Used by n3h developers only. Will get removed soon.

[lucksus]

@thedavidmeister, @Connoropolous, @ddd-mtl, ok to merge?

[Connoropolous]

I'm an approve and since Davids change request was only regarding documentation, which is now addressed, I propose you can dismiss the review and go ahead

[lucksus]

I‘ve turned this into a WIP since REAL Mode seems to have problems still while HACK works. Let us merge this after REAL mode got fixed.

[ddd-mtl]

@lucksus Agree on postponing this.
On my side, waiting on Core to do integration test and isolating the hypothetical problem before looking into a potential fix.

[lucksus]

@ddd-mtl, did we not identify conceptual issues that will take ~ 2 weeks solving anyway? Shouldn't we start working on that asap? @neonphog?

[lucksus]

Also, until we have core <> n3h integration tests we can only manually run apps to test integration as I did so far with holochain-basic-chat. But that is a possibility in the now. I stopped doing that for solving the issues in REAL mode because HACK mode seems to be working and sufficient for getting to working apps via the internet as soon as we solve the IPv6/zerotier issues..

[ddd-mtl]

@lucksus Yes, the other issue is n3h stores entries & metas without waiting for Core to validate it. This is not blocking so not a priority.