This repository has been archived by the owner on Feb 3, 2023. It is now read-only.
Add validation for agent entry #1497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willemolding
commented
Jun 10, 2019
| @@ -0,0 +1,62 @@ | |||
| use crate::{ | |||
There was a problem hiding this comment.
This file is really the only new piece of core code. The rest is fixing tests and dealing with the macros
…olochain/holochain-rust into add-validation-for-agent-entry
thedavidmeister
approved these changes
Jun 10, 2019
…into add-validation-for-agent-entry
lucksus
suggested changes
Jun 13, 2019
There was a problem hiding this comment.
Awesome!
I've spotted a broken merge in the changelog though.
Also, is there a way to test this?
What would happen currently - without any other changes to n3h/lib3h that are needed to fully implement membranes - if an agent would be invalid? Can we add a test for that?
added 2 commits
June 17, 2019 13:59
# Conflicts: # CHANGELOG-UNRELEASED.md # nodejs_conductor/test/test.dna.json
lucksus
approved these changes
Jun 17, 2019
maackle
approved these changes
Jun 21, 2019
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
To enable membranes there must be a way for agents to validate who is allowed to join. This PR adds some new functionality to enable this by making the AgentId (second entry on the local chain) a validate-able entry with a user defined callback in the zome.
This is a breaking change to existing zomes. Zome developers must add a
validate_agentcallback either using the old HDK or the proc-macro HDK.changelog
Please check one of the following, relating to the CHANGELOG-UNRELEASED.md
- summary of change [PR#1234](https://github.com/holochain/holochain-rust/pull/1234)