This repository has been archived by the owner on Feb 3, 2023. It is now read-only.
Init replaces genesis #1508
Merged
Init replaces genesis #1508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zippy
approved these changes
Jun 13, 2019
…into init-replaces-genesis
…holochain-rust into init-replaces-genesis
lucksus
suggested changes
Jul 23, 2019
Co-Authored-By: Nicolas Luck <nicolas@lucksus.eu>
StaticallyTypedAnxiety
approved these changes
Jul 23, 2019
lucksus
approved these changes
Jul 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Since we are no longer going to have a genesis function but rather a validate capability grant callback I think it makes sense to merge this now.
Init replaces genesis in define_zome! and proc macro HDK. It takes some init params which is a JsonString entered in the conductor config.
It is also now possible to call hdk functions in init since it is no longer performing validation. init is more like a regular zome function that is called on startup. The membrane enforcement is now done by the
validate_agentand soon thevalidate_capabilitycallbacks.changelog
Please check one of the following, relating to the CHANGELOG-UNRELEASED.md
- summary of change [PR#1234](https://github.com/holochain/holochain-rust/pull/1234)