This repository has been archived by the owner on Feb 3, 2023. It is now read-only.
Proc macro cli template #1511
Merged
Proc macro cli template #1511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willemolding
requested review from
zippy,
thedavidmeister and
Connoropolous
and removed request for
zippy
lucksus
approved these changes
Jun 13, 2019
struktured
suggested changes
Jun 19, 2019
zippy
approved these changes
Jun 19, 2019
There was a problem hiding this comment.
Approved. But @struktured & @willemolding , please note that we'll have to update the reference to holochain_core_types_derive when the separate of that crate gets finalized.
struktured
approved these changes
Jun 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Adds a new option to
hc generateto use generate a zome using the procedural macro HDK rather than the old define_zome! macro.e.g.
hc generate <zome_name> rust-procIt would be nice if this was ready for the dev camp.
changelog
Please check one of the following, relating to the CHANGELOG-UNRELEASED.md
- summary of change [PR#1234](https://github.com/holochain/holochain-rust/pull/1234)