This repository has been archived by the owner on Feb 3, 2023. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucksus
requested review from
willemolding,
maackle and
zippy
and removed request for
maackle,
willemolding and
zippy
June 15, 2019 19:13
lucksus
commented
Jun 15, 2019
willemolding
approved these changes
Jun 17, 2019
This is amazing. So excited to play around with it. |
…Json instead of using json!{}
zippy
approved these changes
Jun 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Approving for functionality, but I notice that there's nothing in the MD Book. Can you please at least add a place-holder so that we don't forget?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great in basic chat
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
This adds an HDK function:
which will send
Signal::UserSignal
s over the signal channel and websocket interface to the UI where it can be listened to like so:So it is a bare-bones signal implementation without all the checks and DNA defintions that we were hinting towards in the Signals ADR.
But it should be enough to get Basic-Chat rolling with a UI that refreshes automatically and without polling :) (pinging @philipbeadle and @willemolding)
Is using some changes to Diorama to actually test if signals arrive at the interface client.
followups
changelog
- summary of change [PR#1234](https://github.com/holochain/holochain-rust/pull/1234)