Skip to content
This repository has been archived by the owner on Feb 3, 2023. It is now read-only.

Diorama scaffold tests #1532

Merged
merged 6 commits into from Jun 19, 2019
Merged

Diorama scaffold tests #1532

merged 6 commits into from Jun 19, 2019

Conversation

willemolding
Copy link
Collaborator

PR summary

Another little one. Changes the test skeleton produced by hc init to use diorama.js instead of holochain-nodejs.

Running

hc init test_dna
cd test_dna/zomes && hc generate my_zome && cd ..
hc test

results in tests running and passing using diorama.

changelog

Please check one of the following, relating to the CHANGELOG-UNRELEASED.md

  • this is a code change that effects some consumer (e.g. zome developers) of holochain core so it is added to the CHANGELOG-UNRELEASED.md (linked above), with the format - summary of change [PR#1234](https://github.com/holochain/holochain-rust/pull/1234)
  • this is not a code change, or doesn't effect anyone outside holochain core development

@willemolding willemolding requested review from Connoropolous, zippy, lucksus and maackle and removed request for zippy June 19, 2019 06:03
Copy link
Collaborator

@Connoropolous Connoropolous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! follow up should be getting that CI test that actually tests the scaffold code merged too so that we don’t forget about this dependency on diorama and break things for the CLi constantly

Copy link
Collaborator

@lucksus lucksus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!
I've just published the next Diorama version. Let's include the new version in here already.

cli/src/cli/js-tests-scaffold/package.json Outdated Show resolved Hide resolved
@Connoropolous Connoropolous merged commit a07aca3 into develop Jun 19, 2019
@maackle
Copy link
Member

maackle commented Jun 20, 2019

🙌 thanks!

@zippy zippy deleted the diorama-scaffold-tests branch October 4, 2019 18:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants