Skip to content
This repository has been archived by the owner on Feb 3, 2023. It is now read-only.

Fix chain headers for validation package #926

Merged
merged 9 commits into from Jan 30, 2019
Merged

Fix chain headers for validation package #926

merged 9 commits into from Jan 30, 2019

Conversation

Connoropolous
Copy link
Collaborator

@Connoropolous Connoropolous commented Jan 28, 2019 •
edited

  • I have added a summary of my changes to the changelog

@Connoropolous Connoropolous requested review from zippy, sphinxc0re, lucksus and maackle and removed request for zippy, sphinxc0re and lucksus January 28, 2019 16:52
zippy
zippy approved these changes Jan 29, 2019
View reviewed changes
Copy link
Member

@zippy zippy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this was a mistake before, you can't validate a chain without ALL the headers.

@Connoropolous Connoropolous merged commit 11b6949 into develop Jan 30, 2019
@zippy zippy deleted the headers-package-fix branch July 4, 2019 19:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zippy zippy zippy approved these changes

@lucksus lucksus lucksus approved these changes

@sphinxc0re sphinxc0re Awaiting requested review from sphinxc0re

@maackle maackle Awaiting requested review from maackle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Connoropolous @zippy @lucksus