Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remote signal via notify #1075

Merged
merged 6 commits into from Nov 2, 2021
Merged

remote signal via notify #1075

merged 6 commits into from Nov 2, 2021

Conversation

neonphog
Copy link
Contributor

@neonphog neonphog commented Oct 27, 2021 •
edited

Summary

  • Switches remote_signal to use kitsune notify mechanism
  • Also, instead of waiting for the notify semaphore, it gives up

TODO:

  • CHANGELOG(s) updated with appropriate info

freesig
freesig suggested changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@freesig freesig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except maybe we can remove the spawn?

crates/holochain/src/core/ribosome/host_fn/remote_signal.rs Show resolved Hide resolved
@neonphog neonphog requested a review from freesig October 28, 2021 17:10
@neonphog neonphog merged commit 6cbc664 into develop Nov 2, 2021
@neonphog neonphog deleted the remote-signal-via-notify branch November 2, 2021 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maackle maackle maackle approved these changes

@freesig freesig freesig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@neonphog @maackle @freesig