Db refactor 1 #1091
Db refactor 1 #1091
Conversation
|
|
||
| // Temporary workaround until we remove the need for a | ||
| // single validator in the next PR. | ||
| let validator = match vault.kind() { | ||
| DbKind::Cell(id) => id.agent_pubkey().clone(), | ||
| _ => unreachable!(), | ||
| }; |
There was a problem hiding this comment.
Things like this will be removed in the follow up PRs
| todo!() | ||
| // ok_fut(Ok(self.sb.share(|sb| { | ||
| // let agent = sb | ||
| // .node_for_local_agent_hash_mut(&*to_agent) | ||
| // .unwrap() | ||
| // .local_agent_by_hash_mut(&*to_agent) | ||
| // .unwrap(); | ||
| // for (hash, op_data) in ops { | ||
| // let loc8 = hash.get_loc().as_loc8(); | ||
| // // TODO: allow setting integration status | ||
| // agent.ops.insert( | ||
| // loc8, | ||
| // AgentOpEntry { | ||
| // is_integrated: true, | ||
| // }, | ||
| // ); | ||
| // } | ||
| // }))) |
There was a problem hiding this comment.
@maackle This is what I was talking to you about. It doesn't make sense to do things like .node_for_local_agent_hash_mut(&*to_agent). Any idea how we can change this?
| .. | ||
| } => { | ||
| let from_agent = super::agent_info::agent_info(_ribosome, call_context.clone(), ())? | ||
| .agent_latest_pubkey; |
There was a problem hiding this comment.
just curiosity, why is it "latest", does the pubkey iterate somehow in this context?
There was a problem hiding this comment.
@neonphog yeah there's an "initial" as well
| if finished && con.peer_cert() == *endpoint.cert() { | ||
| i.initiate_tgt = None; | ||
| } | ||
| let futs = bloom.inner.share_mut(move |i, _| { |
There was a problem hiding this comment.
Are we ready to delete simple_bloom yet? If everybody's switched over to the default sharded_gossip, we shouldn't spend cycles maintaining something that isn't needed.
There was a problem hiding this comment.
Yeh sounds like a good idea, maybe in a separate PR?
freesig
added
the
NO-MERGE (dependency)
|
Unfortunately I made a mistake that is a little hard to fix in this PR but will be fixed in a follow up so even though this is approved I won't merge it but instead pull it into |
Summary
This is the first PR in the db refactor series.
HolochainP2pCellto HolochailP2pDna`.There's a few little work arounds just to make this PR work until the next which will remove them.
I will post the next PR once this is merged due to the size and potential for conflicts.
Overall there's a lot of noise from name changes but it's a pretty simple PR.
TODO: