Kitsune host logic #1267
Merged
Kitsune host logic #1267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maackle
force-pushed
the
kitsune-host-logic
branch
from
a286538
to
45826da
Compare
…ixup-owners release-automation: extract ensure-crate-owners as subcommand and add github action test
maackle
force-pushed
the
kitsune-host-logic
branch
from
45826da
to
7cfa4c1
Compare
maackle
force-pushed
the
kitsune-host-logic
branch
from
7cfa4c1
to
6ef1d2f
Compare
neonphog
reviewed
Mar 3, 2022
|
|
||
| /// The interface to be implemented by the host, which handles various requests | ||
| /// for data | ||
| pub trait KitsuneHost { |
There was a problem hiding this comment.
I vote for putting some additional explicit bounds on this trait, it tends to move any compile errors inwards closer to where the actual coding issue is.
Suggested change
| pub trait KitsuneHost { | |
| pub trait KitsuneHost: 'static + Send + Sync { |
neonphog
reviewed
Mar 3, 2022
| /// A supertrait of KitsuneHost convenient for defining test handlers. | ||
| /// Allows only specifying the methods you care about, and letting all the rest | ||
| /// panic if called | ||
| pub trait KitsuneHostPanicky: KitsuneHost { |
neonphog
reviewed
Mar 3, 2022
| use std::collections::{HashMap, HashSet}; | ||
|
|
||
| use anyhow::bail; | ||
| use anyhow::{bail, Context}; |
There was a problem hiding this comment.
are the changes in this file / crate a weird merge conflict?
There was a problem hiding this comment.
Must be because this PR isn't based on develop
neonphog
approved these changes
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a trait-based way for kitsune to make requests of its host, rather than ghost_actor.
Converts both KGenReq sub-methods, as well as get_agent_info_signed (chosen somewhat at random) to this new method, to prove that it works. The rest of the methods can be converted at another time.
TODO:
CHANGELOG(s) updated with appropriate info