Unidirectional arcs pt. 2 #1283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a huge change, particularly to gossip behavior. With bidirectional arcs, when peers have roughly equivalently sized arcs, half of the peers who have overlapping arcs will not see each other or gossip with each other because their centerpoints are not contained within each others' arcs. With unidirectional arcs, this problem is removed at the expense of making peer discovery asymmmetrical.
This reverts commit 5b76ccd.
Unidirectional arcs pt. 4: split DhtArc into two types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Unidirectional Arcs PR #1282 originally contained a re-org of some structs which made the diff hard to read. I reverted that change and the reverted the reversion in this PR. So, this PR contains only reorganization, no logical changes.
Since it's hard to read from the diff, the reorg is as follows:
(This reverts commit 5b76ccd.)
Summary
TODO:
CHANGELOG(s) updated with appropriate info