Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2022 03 21 compound external #1308

Merged
merged 11 commits into from Apr 5, 2022
Merged

Conversation

thedavidmeister
Copy link
Contributor

@thedavidmeister thedavidmeister commented Mar 22, 2022

Summary

  • Creates a compound type for linking that includes external hashes as AnyLinkableHash
  • Implements AnyLinkableHash for link bases and targets

TODO:

  • CHANGELOG(s) updated with appropriate info
  • Just before pressing the merge button, ensure new entries to CHANGELOG(s) are still under the UNRELEASED heading

Changes to code

ALL LINKS NEED A .into() ON THEIR HASHES to convert the old entry hashes into compound hashes automatically

@thedavidmeister thedavidmeister changed the title WIP: 2022 03 21 compound external 2022 03 21 compound external Mar 29, 2022
Copy link
Member

@maackle maackle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@pdaoust
Copy link
Contributor

pdaoust commented Mar 29, 2022

Added an update to docs in #1316 -- requesting that it be merged into this PR's branch 🙏🏼

@thedavidmeister thedavidmeister added the hdk Involves changes to the HDK label Mar 30, 2022
…doc-update

Docs update for external hashes
@thedavidmeister thedavidmeister merged commit 66d9ca9 into develop Apr 5, 2022
@thedavidmeister thedavidmeister deleted the 2022-03-21-compound-external branch April 5, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hdk Involves changes to the HDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants