New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hdk shared secret api #1410
Merged
Merged
hdk shared secret api #1410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedavidmeister
approved these changes
Jun 14, 2022
crates/holochain/src/core/ribosome/host_fn/x_salsa20_poly1305_encrypt.rs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@thedavidmeister - Here's what I'm thinking for getting the shared secrets into lair, let me know your thoughts:
my_key_type:[32 random bytes]
). But we'll still auto-generate an identifier if they pass in None to either create or ingest.x_salsa20_poly1305_shared_secret_create_random
- generates a random shared secretx_salsa20_poly1305_shared_secret_export
- exports an existing shared secret encrypted as a box for a specific other agentx_salsa20_poly1305_shared_secret_ingest
- which can import shared secrets either exported via hdk or generated from some custom app-specific process.TODO: